fix pointer value set #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 68.60% 68.98% +0.37%
==========================================
Files 28 28
Lines 3217 3140 -77
==========================================
- Hits 2207 2166 -41
+ Misses 775 751 -24
+ Partials 235 223 -12
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlexStocks
approved these changes
May 5, 2023
|
good |
|
dubbo-go integration test , ref apache/dubbo-go#2312 |
wongoo
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
From v1.12.0, hessian starts to support pointer value ref to java wrapper types, but the unit tests does not fully cover all cases. This pr fixes the pointer value set.
Which issue(s) this PR fixes:
Fixes #358
Special notes for your reviewer:
Does this PR introduce a user-facing change?: